Scan primary key column before updating #3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3542 +/- ##
==========================================
- Coverage 90.01% 89.07% -0.94%
==========================================
Files 1190 1202 +12
Lines 42956 43523 +567
==========================================
+ Hits 38668 38770 +102
- Misses 4288 4753 +465 ☔ View full report in Codecov by Sentry. |
andyfengHKU
force-pushed
the
scan-pk-for-set-clause
branch
from
5f2a3d3 to
933f437
Compare
ray6080
approved these changes
May 26, 2024
ted-wq-x
pushed a commit
to ted-wq-x/kuzu
that referenced
this pull request
Nov 14, 2024
* Scan primary key when updating primary key * Run clang-format --------- Co-authored-by: CI Bot <andyfengHKU@users.noreply.github.com> (cherry picked from commit 5d4d5c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes updating logic. When we try to update primary key column. Instead of looking up inside
NodeTable, we now directly scan it in the source scan operator.This PR also refactors set operators.
Fixes # (issue)
Contributor agreement